Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable click command to send #36

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

ruattd
Copy link
Contributor

@ruattd ruattd commented Feb 12, 2024

An option to disable click command text to send the command (to prevent accidental touch).

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: The pull request introduces a new feature allowing users to disable the functionality where clicking on a command text sends the command. This is aimed at preventing accidental touches from triggering commands. The changes include modifications to the ChatActivityEnterView to check for a new configuration flag before processing click commands, and an update to the NekoChatSettingsActivity to allow users to toggle this feature on or off.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

  • Consider alternative control flow mechanisms to the labeled break statement for exiting from the if block. While it achieves the desired functionality, using more conventional structures could improve code readability and maintainability.
  • Ensure thorough testing of the new feature, especially focusing on the interaction between the longPress and disableClickCommandToSend flags, to confirm that the feature behaves as expected across all user scenarios.
  • Document the rationale behind the choice of control flow structures, especially the use of labeled break, to aid future maintainers in understanding the decision-making process behind this implementation.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@omg-xtao omg-xtao closed this Feb 12, 2024
@omg-xtao omg-xtao reopened this Feb 12, 2024
@omg-xtao omg-xtao added the enhancement New feature or request label Feb 12, 2024
@omg-xtao omg-xtao merged commit 90765fd into NextAlone:dev Feb 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants